Skip to content

Conversation

@jsji
Copy link
Contributor

@jsji jsji commented Mar 22, 2025

  • [NVPTX] Aggressively try to replace image handles with references (#119730)
  • [NVPTX]: Fix NVPTXReplaceImageHandles after f9c8c01

AlexMaclean and others added 2 commits March 22, 2025 07:56
…19730)

Even in cases where handles are supported, references are still
preferable for performance. This is because, a ref uses one
less register and can avoid the handle creating code associated with
taking the address of a tex/surf/sampler.
 Conflicts:
	llvm/test/CodeGen/NVPTX/surf-read-cuda.ll
	llvm/test/CodeGen/NVPTX/surf-tex.py
	llvm/test/CodeGen/NVPTX/surf-write-cuda.ll
	llvm/test/CodeGen/NVPTX/tex-read-cuda.ll
@jsji jsji requested a review from a team as a code owner March 22, 2025 15:00
@jsji jsji temporarily deployed to WindowsCILock March 22, 2025 15:00 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 22, 2025 16:18 — with GitHub Actions Inactive
@jsji jsji closed this Mar 28, 2025
@jsji jsji reopened this Mar 28, 2025
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 14:39 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 16:19 — with GitHub Actions Inactive
@jsji jsji temporarily deployed to WindowsCILock March 28, 2025 16:19 — with GitHub Actions Inactive
@jsji jsji closed this May 2, 2025
@jsji jsji deleted the reland branch May 2, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants